tetragon: un/pin fixes #3079
Open
tetragon: un/pin fixes #3079
+310
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since linux kernel commit [1] we need to have O_RDWR to get link object properly. Use O_RDWR (nil for opts) in ebpf.LoadPinnedMap calls that face the path for the first time and stumble on link pin and fail. [1] 25fc94b2f02d bpf: link: Refuse non-O_RDWR flags in BPF_OBJ_GET Signed-off-by: Jiri Olsa <[email protected]>
Now when we create link pins by default all sensor unloads remove link pin and because bpf pinned links removal is asynchronous, we need to wait to be sure it's gone. Signed-off-by: Jiri Olsa <[email protected]>
Add proper 'override' suffix to the link path for kprobe multi attach override link. Signed-off-by: Jiri Olsa <[email protected]>
Add proper 'override' suffix to the link path for fmodret attach override link. Signed-off-by: Jiri Olsa <[email protected]>
It's not used. Signed-off-by: Jiri Olsa <[email protected]>
Make sure we unpin link when closing the link. Signed-off-by: Jiri Olsa <[email protected]>
Now when we remove pins when we unload sensor/program, we can pin links unconditionally. Signed-off-by: Jiri Olsa <[email protected]>
Store KeepSensorsOnExit flag in SensorManager and use it when sensors go down to instruct sensor unload path to unpin or leave all the pins (progs/maps/links). The sensor level support comes in following change. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/on_exit
branch
from
0372a21
to
a74ba3d
Compare
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/on_exit
branch
3 times, most recently
from
ff5dab6
to
fa5b10d
Compare
Propage unpin flag from sensor.Unload/Destroy down to the unloader level and unpin progs/maps/links only when instructed by the unpin argument. Signed-off-by: Jiri Olsa <[email protected]>
It unloads program and it fits better next to the existing LinkUnloader type. Signed-off-by: Jiri Olsa <[email protected]>
Use sensor manager with the new KeepSensorsOnExit setup instead of loading sensors manually. Signed-off-by: Jiri Olsa <[email protected]>
Add persistent enforcement test that simulates tetragon normal exit, WITHOUT KeepSensorsOnExit and make sure the enforcement is removed. Signed-off-by: Jiri Olsa <[email protected]>
Add persistent enforcement test that simulates enforcement policy unload (not exit) with KeepSensorsOnExit and make sure the enforcement is removed. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/on_exit
branch
from
fa5b10d
to
d4b21c0
Compare
mtardy
approved these changes
Nov 7, 2024
| run(1, expected) | ||
|
|
||
| // remove the policy and we should get rid of the enforcement | ||
| err = mgr.DeleteTracingPolicy(ctx, tp.TpName(), "") |
There was a problem hiding this comment.
In the commit you specify "test that simulates enforcement policy unload (not exit)" but you use Delete instead of DisableTracingPolicy, is that intended? You don't exactly test the scenario here #3033, maybe you want to modify one or add another one?
There was a problem hiding this comment.
I see, it should be about the same, but I can add that scenario as well, thnx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factor sensors unpin-ing
fixes #3033